chore: upgrade to node 22 #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecxyzzy
reviewed
Nov 27, 2024
ecxyzzy
reviewed
Nov 28, 2024
Comment on lines
+646
to
647
| .toArray() | ||
| .map(([meetingId, v]) => { |
There was a problem hiding this comment.
Sorry I'm dumb and missed this 🤦 This can be map then toArray as well
ecxyzzy
reviewed
Nov 28, 2024
| .map(([key, rank]) => ({ | ||
| type: "course" as const, | ||
| result: getFromMapOrThrow(courses, key), | ||
| rank, | ||
| })) | ||
| .toArray() | ||
| .slice(input.skip, input.skip + input.take), |
There was a problem hiding this comment.
Also missed this - can be converted to .drop and .take
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to node 22 and refactor usages of
Array.fromtoiterator.toArray()Related Issue
closes #32
Motivation and Context
How Has This Been Tested?
Ran scrapers locally and tested changed services by hitting endpoints
Screenshots (if appropriate):
Types of changes
Checklist: